Bug 256640 – Partial Sync 'TextDecoderStream.idl' based on WebIDL Spec

• Component: DOM
• Status: RESOLVED CONFIGURATION CHANGED

[Ahmad Saleem]

Hi Team,

It is just to align WebKit's TextDecoderStream.idl file with Web-Spec:

Web-Spec: https://encoding.spec.whatwg.org/#interface-textdecoderstream

We have:

constructor(optional DOMString label, optional any options);

While as per spec, it should be:

constructor(optional DOMString label = "utf-8", optional TextDecoderOptions options = {});

___________

Changing above works and does progress any WPT but align us with web-spec.

___________

Similarly, spec has also to add this:

TextDecoderStream includes TextDecoderCommon;
TextDecoderStream includes GenericTransformStream;

___________

But just want it to be partial to fix 'constructor' bit rather than latter.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/109508762>

[Anne van Kesteren]

Youenn should probably look at this. It's not clear to me this helps as it's implemented in JS rather than C++.

[youenn fablet]

I think this is handled by JS built-in.
As a pure refactoring, we could try to move this code to C++ now that we have better C++ wrappers for readable/writable.

[Ahmad Saleem]

I raised this because we were still failing three WPT test cases (sub-tests here):

https://wpt.fyi/results/encoding/idlharness.any.html?label=master&label=experimental&aligned&q=safari%3Afail

Live Link - http://wpt.live/encoding/idlharness.any.html

_________

>> TextDecoderStream interface: attribute encoding	
>> TextDecoderStream interface: attribute fatal	
>> TextDecoderStream interface: attribute ignoreBOM	

___

We fail one in 'TextEncoderStream' as well:

>> TextEncoderStream interface: attribute encoding

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #4)
> I raised this because we were still failing three WPT test cases (sub-tests
> here):
> 
> https://wpt.fyi/results/encoding/idlharness.any.
> html?label=master&label=experimental&aligned&q=safari%3Afail
> 
> Live Link - http://wpt.live/encoding/idlharness.any.html
> 
> _________
> 
> >> TextDecoderStream interface: attribute encoding	
> >> TextDecoderStream interface: attribute fatal	
> >> TextDecoderStream interface: attribute ignoreBOM	
> 
> ___
> 
> We fail one in 'TextEncoderStream' as well:
> 
> >> TextEncoderStream interface: attribute encoding

Ignore - running directly in Safari 17 - we pass it (macOS Sonoma).

[Ahmad Saleem]

We are passing this now reliably in Safari Technology Preview 181 in WPT runs.

Closing as 'RESOLVED CONFIGURATION CHANGED'.