Bug 256528
Summary: | Sync `hr` element UA stylesheet for missing 'color: gray' | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | annevk, karlcow, ntim, simon.fraser, webkit-bug-importer |
Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
Version: | Safari Technology Preview | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | http://wpt.live/html/rendering/non-replaced-elements/the-hr-element-0/hr.html |
Ahmad Saleem
HI Team,
While looking into failing testcase on WPT, I noticed that Firefox is passing this test case:
WPT Link - https://wpt.fyi/results/html/rendering/non-replaced-elements/the-hr-element-0/hr.html?label=experimental&label=master&aligned
Color - !EQ("rgb(128, 128, 128)", "rgb(0, 0, 0)")
While looking at HTML Standard: https://html.spec.whatwg.org/#the-hr-element-2
I noticed that it has:
color: gray;
^ it is also present in 'Firefox' html.css file (UA stylesheet).
Adding this in local build and checking above testcase, we start to pass failing test case.
Just wanted to raise so we can fix this and if we have any reason to not do this then we can do so.
NOTE - we are doing opposite in this regard for <table> border to ask for removing 'color: gray' while asking to have it for 'hr' element.
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Karl Dubost
We could do it. I don't think there is an issue against it.
Ahmad Saleem
(In reply to Karl Dubost from comment #1)
> We could do it. I don't think there is an issue against it.
My only concern is that WebKit had ‘table-border: gray’ and standards said a ‘Nope’, you have ‘black’ as default but nothing from UA Stylesheet and now we have web-spec saying for ‘gray’ to be in UA stylesheet. It seems like two opposite things to do in forcing colors.
Anne van Kesteren
Given that Chromium and WebKit match I would suggest raising an issue against whatwg/html to get the standard changed.
Tim Nguyen (:ntim)
I think all browsers display it gray, or some variation. Blink & WebKit display it at rgb(154,154,154) which is close to gray (rgb(128,128,128)).
The only difference is that the spec suggests to use `border-color: currentColor` and then set the `color` to the actual color (which is nicer, since you can tweak the color the HR using the color property as well).
Radar WebKit Bug Importer
<rdar://problem/109409002>
Ahmad Saleem
*** This bug has been marked as a duplicate of bug 258725 ***