Bug 256525
| Summary: | Clamp frameset cols/rows values safely to integers for absolute & percentage | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Frames | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=256764 | ||
Ahmad Saleem
Hi Team,
While looking at 'frameset' failure, I came across another Blink commit, which can lead to passes on WPT:
Failing WPT Tests: https://wpt.fyi/results/html/rendering/non-replaced-elements/the-frameset-and-frame-elements?label=master&label=experimental&aligned=&q=frameset
large-cols-abssize.html
large-cols-percentage.html
large-cols-relsize.html
large-rows-abssize.html
large-rows-percentage.html
large-rows-relsize.html
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/7091ff7be362763203b68fb09f48898258df0c37
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFrameSet.cpp#186
Just wanted to raise, so this can be fixed. I tried locally to do clampTo<int> but these tests still fail, so it might be not my expertise area.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109407606>
Ahmad Saleem
For some reason, it does not lead to progressions on GTK-WK2 and WPE-WK2. I am closing my PR.
PR - https://github.com/WebKit/WebKit/pull/13858
But anyone from GTK-WK2 team, who can help in investigating the failures?