Bug 256496

Summary: AX: Fix various ITM tests after 263832@main
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, rniwa, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tyler Wilcock 2023-05-08 15:55:46 PDT
263832@main changed the timing of AX object cache updates that some of our tests implicitly relied on. These tests need to be made properly async to be immune to timing changes. This change also exposes bugs where we dereference a null AXObjectCache assuming it will always be present -- we cannot make those assumptions in some contexts anymore.
Comment 1 Radar WebKit Bug Importer 2023-05-08 15:56:01 PDT
<rdar://problem/109063886>
Comment 2 Tyler Wilcock 2023-05-08 16:00:52 PDT
Created attachment 466289 [details]
Patch
Comment 3 Tyler Wilcock 2023-05-08 17:56:16 PDT
Created attachment 466291 [details]
Patch
Comment 4 EWS 2023-05-09 00:01:59 PDT
Committed 263854@main (d57954fad0e9): <https://commits.webkit.org/263854@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466291 [details].