Bug 256438 – REGRESSION (244460@main): Stop using RetainPtr<>::autorelease() in createNSArray() lambda

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Stop using RetainPtr<>::autorelease() in createNSArray() lambda.

This is not necessary:

- (NSArray<_WKApplicationManifestIcon *> *)icons
{
    return createNSArray(_applicationManifest->applicationManifest().icons, [] (auto& coreIcon) -> id {
        return adoptNS([[_WKApplicationManifestIcon alloc] initWithCoreIcon:&coreIcon]).autorelease();
    }).autorelease();
}

in Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm.

Regressed in:

    Add support for web app manifest icons in WebKit/UI Process layer
    <https://bugs.webkit.org/show_bug.cgi?id=233350>
    <rdar://problem/84311569>
    <https://commits.webkit.org/244460@main>

[Radar WebKit Bug Importer]

<rdar://problem/109022629>

[David Kilzer (:ddkilzer)]

Pull request: https://github.com/WebKit/WebKit/pull/13559

[EWS]

Committed 263786@main (d57e039ea711): <https://commits.webkit.org/263786@main>

Reviewed commits have been landed. Closing PR #13559 and removing active labels.