Bug 256333
| Summary: | [GPU Process][Filters] Make SVGFilter own a vector of unique FilterEffects | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=257612 | ||
| Bug Depends on: | |||
| Bug Blocks: | 232845 | ||
Said Abou-Hallawa
Currently SVGFilter owns a SVGFilterExpression which is a Vector of SVGFilterExpressionTerm. The SVGFilterExpressionTerm holds a Ref<FilterEffect> which maybe referenced more than once by multiple SVGFilterExpressionTerms.
We need make SVGFilter own a Vector of unique FilterEffects. SVGFilterExpressionTerm will hold an index to this Vector. This will allow building an SVGFilterTransaction which is a set of altered unique FilterEffects identified by the index in the vector of unique FilterEffects of SVGFilter.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109060794>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/13619
EWS
Committed 263886@main (56cc7591e5e3): <https://commits.webkit.org/263886@main>
Reviewed commits have been landed. Closing PR #13619 and removing active labels.