Bug 25601

Summary:

[Qt] Make sure that public APIs are properly exported on all Qt supported platforms

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

manyoso

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed fix.	zecke: review+

Laszlo Gombos

Reported 2009-05-06 19:53:41 PDT

WebCore should define QT_MAKEDLL (in WebCore.pro) for all non-static builds (not just for win) to for properly export all Qt public APIs. ChangeSet 41494 (http://trac.webkit.org/changeset/41494) intended to fix this by defining QT_SHARED in webkitdirs.pm, but since not all the Qt build environments are using the build-webkit perl script to build, WebCore.pro is a better place to fix this. I think QT_MAKEDLL is the proper define to export all Qt public APIs, and not QT_SHARED.

Attachments
Proposed fix. (2.21 KB, patch) 2009-05-06 20:00 PDT, Laszlo Gombos	zecke: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2009-05-06 20:00:28 PDT

Created attachment 30082 [details] Proposed fix.

Holger Freyther

Comment 2 2009-05-11 03:41:25 PDT

Comment on attachment 30082 [details] Proposed fix. thanks.

Holger Freyther

Comment 3 2009-05-11 09:24:06 PDT

Landed in r43497.

Note You need to log in before you can comment on or make changes to this bug.