Summary: | [GTK] Enable more tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jmalonzo, mrobinson | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2009-05-06 17:31:17 PDT
Created attachment 30076 [details]
Implement dumpStatusCallbacks and enable the only test that uses it.
LayoutTests/ChangeLog | 9 +++++++++
LayoutTests/platform/gtk/Skipped | 1 -
WebKitTools/ChangeLog | 10 ++++++++++
WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp | 7 +++++++
4 files changed, 26 insertions(+), 1 deletions(-)
Created attachment 31159 [details]
Enable more http/tests/navigation tests
Enable navigation tests.
Comment on attachment 31159 [details]
Enable more http/tests/navigation tests
woot r=me
I'm so dumb, I forgot to mark my patch for review =P Comment on attachment 30076 [details] Implement dumpStatusCallbacks and enable the only test that uses it. > > +static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar* message, gpointer data) > +{ > + if (gLayoutTestController->dumpStatusCallbacks()) > + printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message ? message : ""); > +} Looks good. Just curious: are we expecting message to be null? r=me. (In reply to comment #5) > (From update of attachment 30076 [details] [review]) > > > > +static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar* message, gpointer data) > > +{ > > + if (gLayoutTestController->dumpStatusCallbacks()) > > + printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message ? message : ""); > > +} > > Looks good. Just curious: are we expecting message to be null? > > r=me. > That came from the way windows does it. I was not 100% sure that is expected, but decided to err on being cautious. Comment on attachment 31159 [details] Enable more http/tests/navigation tests Landed in r44647. Clearing review flag. Comment on attachment 30076 [details] Implement dumpStatusCallbacks and enable the only test that uses it. Landed in r44632. Clearing review flag. We're up to something ~30,000 tests now. I think we should address the rest on a case by case basis. Can't believe I'm about to close this bug! |