Bug 25599

Summary:

[GTK] Enable more tests

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jmalonzo, mrobinson

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Implement dumpStatusCallbacks and enable the only test that uses it.	none
Enable more http/tests/navigation tests	none

Gustavo Noronha (kov)

Reported 2009-05-06 17:31:17 PDT

We have loads of tests in our Skipped list. This bug is an effort to enable more of them.

Attachments
Implement dumpStatusCallbacks and enable the only test that uses it. (2.80 KB, patch) 2009-05-06 17:31 PDT, Gustavo Noronha (kov)	no flags	Details Formatted Diff Diff
Enable more http/tests/navigation tests (4.92 KB, patch) 2009-06-11 04:51 PDT, Jan Alonzo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2009-05-06 17:31:58 PDT

Created attachment 30076 [details] Implement dumpStatusCallbacks and enable the only test that uses it. LayoutTests/ChangeLog | 9 +++++++++ LayoutTests/platform/gtk/Skipped | 1 - WebKitTools/ChangeLog | 10 ++++++++++ WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp | 7 +++++++ 4 files changed, 26 insertions(+), 1 deletions(-)

Jan Alonzo

Comment 2 2009-06-11 04:51:39 PDT

Created attachment 31159 [details] Enable more http/tests/navigation tests Enable navigation tests.

Gustavo Noronha (kov)

Comment 3 2009-06-11 07:34:35 PDT

Comment on attachment 31159 [details] Enable more http/tests/navigation tests woot r=me

Gustavo Noronha (kov)

Comment 4 2009-06-11 07:35:28 PDT

I'm so dumb, I forgot to mark my patch for review =P

Jan Alonzo

Comment 5 2009-06-12 05:14:24 PDT

Comment on attachment 30076 [details] Implement dumpStatusCallbacks and enable the only test that uses it. > > +static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar* message, gpointer data) > +{ > + if (gLayoutTestController->dumpStatusCallbacks()) > + printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message ? message : ""); > +} Looks good. Just curious: are we expecting message to be null? r=me.

Gustavo Noronha (kov)

Comment 6 2009-06-12 10:32:39 PDT

(In reply to comment #5) > (From update of attachment 30076 [details] [review]) > > > > +static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar* message, gpointer data) > > +{ > > + if (gLayoutTestController->dumpStatusCallbacks()) > > + printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message ? message : ""); > > +} > > Looks good. Just curious: are we expecting message to be null? > > r=me. > That came from the way windows does it. I was not 100% sure that is expected, but decided to err on being cautious.

Jan Alonzo

Comment 7 2009-06-12 19:42:43 PDT

Comment on attachment 31159 [details] Enable more http/tests/navigation tests Landed in r44647. Clearing review flag.

Jan Alonzo

Comment 8 2009-06-12 19:43:22 PDT

Comment on attachment 30076 [details] Implement dumpStatusCallbacks and enable the only test that uses it. Landed in r44632. Clearing review flag.

Martin Robinson

Comment 9 2012-02-03 15:44:11 PST

We're up to something ~30,000 tests now. I think we should address the rest on a case by case basis. Can't believe I'm about to close this bug!

Note You need to log in before you can comment on or make changes to this bug.