Bug 25589

Summary:

goto instead of state machine in lexer

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

JavaScriptCore

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
work in progress	none
patch for perf testing	none
Perf testing results	none
patch	sam: review+

Darin Adler

Reported 2009-05-06 10:11:44 PDT

Working on this.

Attachments
work in progress (44.48 KB, patch) 2009-05-06 10:12 PDT, Darin Adler	no flags	Details Formatted Diff Diff
patch for perf testing (45.33 KB, patch) 2009-05-06 15:31 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Perf testing results (3.48 KB, text/plain) 2009-05-06 15:41 PDT, Brady Eidson	no flags	Details
patch (47.68 KB, patch) 2009-05-06 17:03 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2009-05-06 10:12:06 PDT

Created attachment 30054 [details] work in progress

Darin Adler

Comment 2 2009-05-06 15:31:57 PDT

Created attachment 30070 [details] patch for perf testing

Brady Eidson

Comment 3 2009-05-06 15:41:19 PDT

Created attachment 30071 [details] Perf testing results Appears to be about 0.8% speedup overall, but possible significant slowdown on bitwise-and and spectral-norm. Then again those two are so fast it may be noise.

Brady Eidson

Comment 4 2009-05-06 15:51:17 PDT

In addition to possible slowdowns, nbody takes a 1.5% hit.

Darin Adler

Comment 5 2009-05-06 17:03:26 PDT

Created attachment 30075 [details] patch

Darin Adler

Comment 6 2009-05-07 13:04:14 PDT

http://trac.webkit.org/changeset/43358

Note You need to log in before you can comment on or make changes to this bug.