Bug 255728

Summary: Result of -webkit-line-clamp with block children may be incorrect during partial repint
Product: WebKit Reporter: Ethan Wong <bunnnywong>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, bfulgham, simon.fraser, zalan
Priority: P2    
Version: Safari 16   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test case to reproduce this issue
none
Expected result for the test case
none
Expected result for the test case none

Ethan Wong
Reported 2023-04-20 08:30:19 PDT
Created attachment 466009 [details] Test case to reproduce this issue visibleLineCountForLineClamp for individual child should be propagated to the parent layoutState.
Attachments
Test case to reproduce this issue (479 bytes, text/html)
2023-04-20 08:30 PDT, Ethan Wong 		no flags
Details
Expected result for the test case (270 bytes, text/html)
2023-04-20 08:31 PDT, Ethan Wong 		no flags
Details
Expected result for the test case (259 bytes, text/html)
2023-04-20 09:02 PDT, Ethan Wong 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ethan Wong
Comment 1 2023-04-20 08:31:01 PDT
Created attachment 466010 [details] Expected result for the test case
Ethan Wong
Comment 2 2023-04-20 08:35:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12973
Ethan Wong
Comment 3 2023-04-20 09:02:12 PDT
Created attachment 466011 [details] Expected result for the test case
Ahmad Saleem
Comment 4 2023-04-25 03:41:02 PDT
(In reply to Ethan Wong from comment #2) > Pull request: https://github.com/WebKit/WebKit/pull/12973 This PR points to different bug? PR just landed. Is this duplicate of bug 255487?
Ethan Wong
Comment 5 2023-04-25 05:42:50 PDT
(In reply to Ahmad Saleem from comment #4) > (In reply to Ethan Wong from comment #2) > > Pull request: https://github.com/WebKit/WebKit/pull/12973 > > This PR points to different bug? > > PR just landed. Is this duplicate of bug 255487? The above PR should point to this bug. It seems the bug id is mistaken. The two bugs results visually similar issue, could probably be merged together.
Ahmad Saleem
Comment 6 2023-04-25 06:13:49 PDT
(In reply to Ethan Wong from comment #5) > (In reply to Ahmad Saleem from comment #4) > > (In reply to Ethan Wong from comment #2) > > > Pull request: https://github.com/WebKit/WebKit/pull/12973 > > > > This PR points to different bug? > > > > PR just landed. Is this duplicate of bug 255487? > > The above PR should point to this bug. It seems the bug id is mistaken. > > The two bugs results visually similar issue, could probably be merged > together. I asked @Alan for his comment on GitHub, once I get input, I will mark this as duplicate or I will revert your change so you can do PR with updated bug URL and then I will push it to main. Again - it is depending on Alan's response. :-) For Reference - https://github.com/WebKit/WebKit/pull/12973#issuecomment-1521570408
Ahmad Saleem
Comment 7 2023-04-25 08:52:37 PDT
This landed in bug 255487 as: Committed 263360@main (59088ba85057): <https://commits.webkit.org/263360@main> Reviewed commits have been landed. Closing PR #12973 and removing active labels. *** This bug has been marked as a duplicate of bug 255487 ***
Note You need to log in before you can comment on or make changes to this bug.