Bug 25555

Summary: [GTK] webkit_web_navigation_action_get_button() documentation
Product: WebKit Reporter: Emilio Pozuelo Monfort <pochu27>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Documentation improvement none

Description Emilio Pozuelo Monfort 2009-05-04 15:37:36 PDT 
The webkit_web_navigation_action_get_button() could be more clear. It just says it returns the mouse button that raised the action.

The first I thought was that it would return a GdkModifierType. kov has told me it just returns 1, 2 or 3, and I have thought the middle button would be 3 and not 2. I think the API description could be more clear. Or maybe I'm just stupid :)
Comment 1 Martin Robinson 2009-12-16 08:41:08 PST 
Created attachment 44980 [details]
Documentation improvement
Comment 2 WebKit Review Bot 2009-12-16 08:44:46 PST 
style-queue ran check-webkit-style on attachment 44980 [details] without any errors.
Comment 3 Gustavo Noronha (kov) 2009-12-16 08:53:26 PST 
Comment on attachment 44980 [details]
Documentation improvement

Awesome. Thanks!
Comment 4 WebKit Commit Bot 2009-12-16 09:04:47 PST 
Comment on attachment 44980 [details]
Documentation improvement

Clearing flags on attachment: 44980

Committed r52198: <http://trac.webkit.org/changeset/52198>
Comment 5 WebKit Commit Bot 2009-12-16 09:04:52 PST 
All reviewed patches have been landed.  Closing bug.