Bug 25555

Summary: [GTK] webkit_web_navigation_action_get_button() documentation
Product: WebKit Reporter: Emilio Pozuelo Monfort <pochu27>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Documentation improvement none

Emilio Pozuelo Monfort
Reported 2009-05-04 15:37:36 PDT
The webkit_web_navigation_action_get_button() could be more clear. It just says it returns the mouse button that raised the action. The first I thought was that it would return a GdkModifierType. kov has told me it just returns 1, 2 or 3, and I have thought the middle button would be 3 and not 2. I think the API description could be more clear. Or maybe I'm just stupid :)
Attachments
Documentation improvement (2.28 KB, patch)
2009-12-16 08:41 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2009-12-16 08:41:08 PST
Created attachment 44980 [details] Documentation improvement
WebKit Review Bot
Comment 2 2009-12-16 08:44:46 PST
style-queue ran check-webkit-style on attachment 44980 [details] without any errors.
Gustavo Noronha (kov)
Comment 3 2009-12-16 08:53:26 PST
Comment on attachment 44980 [details] Documentation improvement Awesome. Thanks!
WebKit Commit Bot
Comment 4 2009-12-16 09:04:47 PST
Comment on attachment 44980 [details] Documentation improvement Clearing flags on attachment: 44980 Committed r52198: <http://trac.webkit.org/changeset/52198>
WebKit Commit Bot
Comment 5 2009-12-16 09:04:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.