Bug 255439
| Summary: | always use document URL as the source of a ResizeObserver loop limit error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> |
| Component: | DOM | Assignee: | Cameron McCormack (:heycam) <heycam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Cameron McCormack (:heycam)
In Document::updateResizeObservations we throw an error if we exceed some limit for the number of times we loop processing ResizeObserver notifications. This uses getParserLocation to get the location to use in the error, which returns the empty string if parsing the document has finished. I think we should just use the document URL. When we pass in the empty string to reportException, we end up censoring the error message as "Script error." because we think the error came from a different origin, and the "ResizeObserver loop completed with undelivered notifications." message gets lost.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Cameron McCormack (:heycam)
rdar://107905388
Cameron McCormack (:heycam)
Pull request: https://github.com/WebKit/WebKit/pull/12729
EWS
Committed 262989@main (7b6d036d50a0): <https://commits.webkit.org/262989@main>
Reviewed commits have been landed. Closing PR #12729 and removing active labels.