Bug 255434
| Summary: | [margin-trim] RenderBox should not be performing trimming | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
RenderBox performs some trimming inside of constrainBlockMarginInAvailableSpaceOrTrim and computeOrTrimInlineMargin as the renderer goes through layout. This has some unfortunate side effects, such as requiring us to set the rare data bits to indicate the margin has been trimmed at the same location. This action requires a const_cast that could be avoided since trimming should not occur at the RenderBox level and should be occurring completely in the layout system it is in (flex, grid, or block). We should make sure that the trimming logic is contained wholly within each layout system and should remove this logic from RenderBox once it is
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/108030923>