Bug 255307

Summary:	[iOS] ASSERTION FAILED: isMainThread() under WebKit::RemoteGraphicsContextGLProxy::RemoteGraphicsContextGLProxy
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	Web Template Framework	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, mattwoodrow, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Ryan Haddad

Reported 2023-04-11 15:22:15 PDT

The following tests are reliably hitting an assert added with https://commits.webkit.org/262749@main imported/w3c/web-platform-tests/webcodecs/videoFrame-texImage.any.worker.html webgl/1.0.x/conformance/offscreencanvas/context-creation-worker.html webgl/1.0.x/conformance/offscreencanvas/context-lost-restored-worker.html webgl/1.0.x/conformance/offscreencanvas/context-lost-worker.html webgl/1.0.x/conformance/offscreencanvas/methods-worker.html webgl/1.0.x/conformance/offscreencanvas/offscreencanvas-timer-query.html webgl/1.0.x/conformance/offscreencanvas/offscreencanvas-transfer-image-bitmap.html webgl/2.0.y/conformance/offscreencanvas/context-creation-worker.html webgl/2.0.y/conformance/offscreencanvas/context-lost-restored-worker.html webgl/2.0.y/conformance/offscreencanvas/context-lost-worker.html webgl/2.0.y/conformance/offscreencanvas/methods-worker.html webgl/2.0.y/conformance/offscreencanvas/offscreencanvas-timer-query.html webgl/2.0.y/conformance/offscreencanvas/offscreencanvas-transfer-image-bitmap.html webgl/2.0.y/conformance2/offscreencanvas/context-creation-worker.html webgl/2.0.y/conformance2/offscreencanvas/methods-2-worker.html webgl/2.0.y/conformance2/offscreencanvas/offscreencanvas-query.html webgl/2.0.y/conformance2/offscreencanvas/offscreencanvas-sync.html webgl/2.0.y/conformance2/offscreencanvas/offscreencanvas-timer-query.html webgl/2.0.y/conformance2/offscreencanvas/offscreencanvas-transfer-image-bitmap.html ASSERTION FAILED: isMainThread() /Volumes/Data/worker/Apple-iOS-16-Simulator-Debug-Build/build/Source/WTF/wtf/ObjectIdentifier.cpp(36) : static uint64_t WTF::ObjectIdentifierMainThreadAccessTraits::generateIdentifierInternal() 1 0x10a649d98 WTFCrash 2 0x10ace8b20 JSC::AbstractSlotVisitor::ReferrerToken::ReferrerToken(JSC::HeapCell*) 3 0x10a6e80a0 WTF::ObjectIdentifierMainThreadAccessTraits::generateIdentifierInternal() 4 0x1302a6380 WTF::ObjectIdentifierGeneric<WebKit::GraphicsContextGLIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>::generate() 5 0x1302a6298 WebKit::RemoteGraphicsContextGLProxy::RemoteGraphicsContextGLProxy(IPC::Connection&, WTF::RefPtr<IPC::StreamClientConnection, WTF::RawPtrTraits<IPC::StreamClientConnection>, WTF::DefaultRefDerefTraits<IPC::StreamClientConnection>>, WebCore::GraphicsContextGLAttributes const&, WTF::Ref<WebKit::RemoteVideoFrameObjectHeapProxy, WTF::RawPtrTraits<WebKit::RemoteVideoFrameObjectHeapProxy>>&&) 6 0x12fc3cc00 WebKit::(anonymous namespace)::RemoteGraphicsContextGLProxyCocoa::RemoteGraphicsContextGLProxyCocoa(IPC::Connection&, WTF::Ref<IPC::StreamClientConnection, WTF::RawPtrTraits<IPC::StreamClientConnection>>, WebCore::GraphicsContextGLAttributes const&, WTF::Ref<WebKit::RemoteVideoFrameObjectHeapProxy, WTF::RawPtrTraits<WebKit::RemoteVideoFrameObjectHeapProxy>>&&) 7 0x12fc393b0 WebKit::(anonymous namespace)::RemoteGraphicsContextGLProxyCocoa::RemoteGraphicsContextGLProxyCocoa(IPC::Connection&, WTF::Ref<IPC::StreamClientConnection, WTF::RawPtrTraits<IPC::StreamClientConnection>>, WebCore::GraphicsContextGLAttributes const&, WTF::Ref<WebKit::RemoteVideoFrameObjectHeapProxy, WTF::RawPtrTraits<WebKit::RemoteVideoFrameObjectHeapProxy>>&&) 8 0x12fc39200 WebKit::RemoteGraphicsContextGLProxy::platformCreate(IPC::Connection&, WTF::Ref<IPC::StreamClientConnection, WTF::RawPtrTraits<IPC::StreamClientConnection>>, WebCore::GraphicsContextGLAttributes const&, WTF::Ref<WebKit::RemoteVideoFrameObjectHeapProxy, WTF::RawPtrTraits<WebKit::RemoteVideoFrameObjectHeapProxy>>&&) 9 0x1302a5eb4 WebKit::RemoteGraphicsContextGLProxy::create(IPC::Connection&, WebCore::GraphicsContextGLAttributes const&, WebKit::RemoteRenderingBackendProxy&, WTF::Ref<WebKit::RemoteVideoFrameObjectHeapProxy, WTF::RawPtrTraits<WebKit::RemoteVideoFrameObjectHeapProxy>>&&) 10 0x130786d44 WebKit::WebWorkerClient::createGraphicsContextGL(WebCore::GraphicsContextGLAttributes const&) const 11 0x146ab6098 WebCore::WebGLRenderingContextBase::create(WebCore::CanvasBase&, WebCore::GraphicsContextGLAttributes&, WebCore::GraphicsContextGLWebGLVersion) 12 0x1469efeb8 WebCore::OffscreenCanvas::createContextWebGL(WebCore::OffscreenCanvas::RenderingContextType, WebCore::GraphicsContextGLAttributes&&) 13 0x1469f09f0 WebCore::OffscreenCanvas::getContext(JSC::JSGlobalObject&, WebCore::OffscreenCanvas::RenderingContextType, WTF::FixedVector<JSC::Strong<JSC::Unknown, (JSC::ShouldStrongDestructorGrabLock)0>>&&) 14 0x14440ec7c WebCore::jsOffscreenCanvasPrototypeFunction_getContextBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSOffscreenCanvas*) 15 0x14440e8bc long long WebCore::IDLOperation<WebCore::JSOffscreenCanvas>::call<&WebCore::jsOffscreenCanvasPrototypeFunction_getContextBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSOffscreenCanvas*), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) 16 0x14440e5fc WebCore::jsOffscreenCanvasPrototypeFunction_getContext(JSC::JSGlobalObject*, JSC::CallFrame*) https://build.webkit.org/results/Apple-iOS-16-Simulator-Debug-WK2-Tests/262829@main%20(911)/results.html

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-04-11 15:22:26 PDT

<rdar://problem/107905440>

Chris Dumez

Comment 2 2023-04-11 15:30:44 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12629

EWS

Comment 3 2023-04-11 15:37:12 PDT

Committed 262846@main (5df7b74b33e3): <https://commits.webkit.org/262846@main> Reviewed commits have been landed. Closing PR #12629 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.