Bug 25513

Summary: V8 CSSStyleDeclaration bindings are slow
Product: WebKit Reporter: Dave Moore <davemoore>
Component: WebKit Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fix
dglazkov: review-
Fix dglazkov: review+

Dave Moore
Reported 2009-05-01 15:33:11 PDT
The V8 bindings convert every javascript property to its associated css style name. It then calls functions that convert that name to an id. This makes getting or setting css styles on elements slow.
Attachments
Fix (8.63 KB, patch)
2009-05-01 15:43 PDT, Dave Moore 		dglazkov: review-
DetailsFormatted DiffDiff
Fix (8.66 KB, patch)
2009-05-06 07:55 PDT, Dave Moore 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Moore
Comment 1 2009-05-01 15:43:11 PDT
Created attachment 29949 [details] Fix
Dimitri Glazkov (Google)
Comment 2 2009-05-05 11:22:41 PDT
Comment on attachment 29949 [details] Fix Just a few nits/comments: > +class CSSPropertyInfo { > + public: align public to class. > + static HashMap<String, CSSPropertyInfo*> map; Use DEFINE_STATIC_LOCAL macro. > + if (!length) > + return NULL; return 0. > + else if (WTF::isASCIIUpper(propertyName[0])) > + return NULL; return 0. > - INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter"); > + //INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter"); Did you mean leave this in?
Dave Moore
Comment 3 2009-05-06 07:55:04 PDT
Created attachment 30049 [details] Fix
Dimitri Glazkov (Google)
Comment 4 2009-05-06 08:57:15 PDT
Comment on attachment 30049 [details] Fix Great! Am I landing it? :)
David Levin
Comment 5 2009-05-06 14:14:15 PDT
Assign to levin for landing.
David Levin
Comment 6 2009-05-06 15:03:22 PDT
http://trac.webkit.org/changeset/43327
Note You need to log in before you can comment on or make changes to this bug.