Bug 25509

Summary: [GTK] Missing accelerator in authentication dialog
Product: WebKit Reporter: Luca Ferretti <elle.uca>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, plaes, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
webkit-bug-25509-add-accelerator zecke: review+

Luca Ferretti
Reported 2009-05-01 01:46:32 PDT
Translating webkitgtk I found this message: #: WebKit/gtk/webkit/webkitsoupauthdialog.c:281 msgid "Remember password" It's referred to checkButton = gtk_check_button_new_with_label(_("Remember password")); in source code. As per GNOME HIG, this checkbox should have an accelerator.
Attachments
webkit-bug-25509-add-accelerator (1.94 KB, patch)
2009-07-20 15:33 PDT, Priit Laes (IRC: plaes) 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Priit Laes (IRC: plaes)
Comment 1 2009-07-20 15:33:28 PDT
Created attachment 33116 [details] webkit-bug-25509-add-accelerator
Holger Freyther
Comment 2 2009-07-20 20:20:16 PDT
Comment on attachment 33116 [details] webkit-bug-25509-add-accelerator As of http://library.gnome.org/devel/hig-book/stable/controls-check-boxes.html.en...
Gustavo Noronha (kov)
Comment 3 2009-07-21 04:05:46 PDT
Landed as r46169.
Luca Ferretti
Comment 4 2009-07-21 04:21:09 PDT
Silly question: POT file needs to be manually updated in order to have this changed message in translations, isn't it?
Note You need to log in before you can comment on or make changes to this bug.