Bug 254873

Summary:	Prevent mixing of generate and generateThreadSafe at compile time
Product:	WebKit	Reporter:	Matt Woodrow <mattwoodrow>
Component:	Web Template Framework	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=255196

Matt Woodrow

Reported 2023-04-01 20:15:41 PDT

generate and generateThreadSafe use separate counters, so mixing usage will results in collisions. We can make this a template parameter instead, and prevent mixing at compile time.

Attachments
Add attachment proposed patch, testcase, etc.

Matt Woodrow

Comment 1 2023-04-02 00:21:38 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12288

EWS

Comment 2 2023-04-07 22:05:20 PDT

Committed 262749@main (1641f98f8e48): <https://commits.webkit.org/262749@main> Reviewed commits have been landed. Closing PR #12288 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2023-04-07 22:06:18 PDT

<rdar://problem/107781219>

Note You need to log in before you can comment on or make changes to this bug.