Bug 25473
| Summary: | Outdent outdents too much | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Julie Parent <jparent> |
| Component: | HTML Editing | Assignee: | Julie Parent <jparent> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | justin.garcia, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Julie Parent
If an indent blockquote contains multiple blocks, and the cursor is in the first block, outdent will outdent the entire blockquote, rather than just the first block. This happens for content like <div>one</div><div>two</div>, not one<br>two.
Example of issue: http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cdiv%20contentEditable%20id%3D'ce'%3E%3Cblockquote%20class%3D%22webkit-indent-blockquote%22%20style%3D%22margin%3A%200%200%200%2040px%3B%20border%3A%20none%3B%20padding%3A%200px%3B%22%3E%3Cdiv%3Eone%3C%2Fdiv%3E%3Cdiv%3Etwo%3C%2Fdiv%3E%3C%2Fblockquote%3E%3C%2Fdiv%3E&ohh=1&ohj=0&jt=var%20ce%20%3D%20gebi('ce')%3B%0Avar%20sel%20%3D%20window.getSelection()%3B%0Asel.setPosition(ce.firstChild.firstChild%2C%200)%3B%0Adocument.execCommand('outdent'%2C%20false%2C%20null)%3B%0A%0Ace.innerHTML&ojh=0&ojj=0&ms=100&oth=0&otj=0&cex=1
Compare to: http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cdiv%20contentEditable%20id%3D'ce'%3E%3Cblockquote%20class%3D%22webkit-indent-blockquote%22%20style%3D%22margin%3A%200%200%200%2040px%3B%20border%3A%20none%3B%20padding%3A%200px%3B%22%3Eone%3Cbr%3Etwo%3C%2Fblockquote%3E%3C%2Fdiv%3E&ohh=1&ohj=0&jt=var%20ce%20%3D%20gebi('ce')%3B%0Avar%20sel%20%3D%20window.getSelection()%3B%0Asel.setPosition(ce.firstChild.firstChild%2C%200)%3B%0A%0Adocument.execCommand('outdent'%2C%20false%2C%20null)%3B%0A%0Ace.innerHTML&ojh=0&ojj=0&ms=100&oth=0&otj=0&cex=1
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
This bug does not reproduce anymore. Assume it has been resolved.
Justin Garcia
Ya this looks fixed, closing.