Summary: | Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler and related callsites | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | timothy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-04-29 16:34:06 PDT
Created attachment 29898 [details]
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler, v1
JavaScriptCore/ChangeLog | 9 +
.../Configurations/FeatureDefines.xcconfig | 3 +-
WebCore/ChangeLog | 18 ++
WebCore/Configurations/FeatureDefines.xcconfig | 3 +-
WebCore/WebCore.vcproj/build-generated-files.sh | 2 +-
WebCore/bindings/js/JSConsoleCustom.cpp | 4 +
WebCore/bindings/js/JSDOMWindowBase.cpp | 5 +-
.../bindings/js/JSInspectorControllerCustom.cpp | 28 +-
WebCore/inspector/InspectorController.cpp | 324 ++++++++++----------
WebCore/inspector/InspectorController.h | 82 +++---
WebCore/inspector/InspectorController.idl | 32 +-
WebCore/page/Console.cpp | 2 +-
WebKit/mac/ChangeLog | 9 +
WebKit/mac/Configurations/FeatureDefines.xcconfig | 3 +-
WebKitTools/ChangeLog | 9 +
WebKitTools/Scripts/build-webkit | 5 +
16 files changed, 299 insertions(+), 239 deletions(-)
Why not add ENABLE_JAVASCRIPT_PROFILER? Basically, two reasons: * They are not mutually exclusive (i.e. you can't really pick one and not the other). There could be some work done to make that happen, which leads us to ... * I consider this a temporary change with minimal effect possible, to unfork and clear way for Inspector rework. I considered renaming JAVASCRIPT_DEBUGGER to be more accurate, like JAVASCRIPT_INSPECTOR, JAVASCRIPT_DEVELOPER_TOOLS or something, but couldn't come up with a name that didn't seem vague. Perhaps that's the route I should with? Landed as http://trac.webkit.org/changeset/43072. GTK fix landed as http://trac.webkit.org/changeset/43074. |