Bug 25469
| Summary: | JS layout tests should support layoutTestController.waitUntilDone/notifyDone. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aroben, hamaji, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Ojan Vafai
Currently tests like platform/win/fast/forms/textarea-metrics-expected.txt that use setTimeout print the SUCCESS line before actually running the test.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ojan Vafai
eseidel's better description from #webkit: the fast/js tests function by including a <Script> tag after your test script which checks to make sure your test script parsed correctly. Instead, we should have a function which that last script calls when you're not waitUntilDone. when you are waitUntilDone then it should not do anything, and you can call the "I'm done" function manually