Bug 254675

Summary: [Margin-trim] Remove a virtual function call on this rare property while computing margins
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

zalan
Reported 2023-03-29 11:12:06 PDT
ssia
Attachments
Patch (10.12 KB, patch)
2023-03-29 11:17 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.12 KB, patch)
2023-03-29 11:43 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.73 KB, patch)
2023-03-29 11:45 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.73 KB, patch)
2023-03-29 12:56 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (9.63 KB, patch)
2023-03-30 19:56 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-03-29 11:17:23 PDT
Created attachment 465665 [details] Patch
Chris Dumez
Comment 2 2023-03-29 11:36:32 PDT
Comment on attachment 465665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465665&action=review > Source/WebCore/rendering/RenderBox.cpp:3796 > +bool RenderBox::shouldTrimChildMargin(MarginTrimType marginTrimType, const RenderBox& child) const Would be nice to make this inline.
zalan
Comment 3 2023-03-29 11:43:08 PDT
Created attachment 465666 [details] Patch
zalan
Comment 4 2023-03-29 11:45:01 PDT
Created attachment 465667 [details] Patch
zalan
Comment 5 2023-03-29 11:45:47 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 465665 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465665&action=review > > > Source/WebCore/rendering/RenderBox.cpp:3796 > > +bool RenderBox::shouldTrimChildMargin(MarginTrimType marginTrimType, const RenderBox& child) const > > Would be nice to make this inline. good point!
Chris Dumez
Comment 6 2023-03-29 12:08:21 PDT
Comment on attachment 465667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465667&action=review r=me > Source/WebCore/rendering/RenderBox.h:313 > + bool shouldTrimChildMargin(MarginTrimType, const RenderBox&) const; This can likely be protected.
zalan
Comment 7 2023-03-29 12:56:28 PDT
Created attachment 465668 [details] Patch
zalan
Comment 8 2023-03-30 19:56:30 PDT
Created attachment 465695 [details] [fast-cq]Patch
EWS
Comment 9 2023-03-31 06:19:35 PDT
Committed 262399@main (dd0e3196e184): <https://commits.webkit.org/262399@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465695 [details].
Radar WebKit Bug Importer
Comment 10 2023-03-31 06:20:17 PDT
<rdar://problem/107469302>
Note You need to log in before you can comment on or make changes to this bug.