Bug 254396
| Summary: | [RemoteInspector][Socket] non-blocking RunLoop::iterate is required | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | haruhisa.shin <haruhisa.shin> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | basuke, fujii.hironori, inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
haruhisa.shin
RemoteInspector's thread for receiving socket data was processing messages via non-blocking RunLoop::iterate().
Since the commit https://github.com/WebKit/WebKit/commit/58887089c1f99919a7879162547ec7cf53548bbe replaced iterate() with cycle(), it is no longer possible to receive sockets.
We need a function that spins RunLoop without blocking the thread, so I propose that the RunLoop::iterate() be reinstated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
haruhisa.shin
Pull request: https://github.com/WebKit/WebKit/pull/11909
EWS
Committed 262188@main (677a38a7599f): <https://commits.webkit.org/262188@main>
Reviewed commits have been landed. Closing PR #11909 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/107294258>
Fujii Hironori
Regressed: Bug 256028 – REGRESSION(262188@main) [Win] TestWTF.WTF_RunLoop.DispatchInRunLoopIterationDispatchesOnNextIteration1 is failing