Bug 254248

Summary:	REGRESSION(261825@main?): [ JSC ] 4X Test262-Tests are constant failures in default and strict mode
Product:	WebKit	Reporter:	Robert Jenner <jenner>
Component:	JavaScriptCore	Assignee:	Yusuke Suzuki <ysuzuki>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=254054

Robert Jenner

Reported 2023-03-21 18:29:13 PDT

The following 4x test-262-tests are constant failures in default and strict mode on macOS Monterey+: test/built-ins/Function/prototype/bind/instance-length-default-value.js test/intl402/Collator/prototype/compare/compare-function-name.js test/intl402/DateTimeFormat/prototype/format/format-function-name.js test/intl402/NumberFormat/prototype/format/format-function-name.js HISTORY: https://build.webkit.org/#/builders/760 Looking at the test runs there appears to be a pretty clear regression point of 261825@main. That's when the tests started to fail, and it appears that the macOS version, Xcode version, and the timezone database version were all the same between 261825@main, the first observed failure and 261824@main, the last time everything was passing. STDIO FAILURE TEXT: FAIL test/built-ins/Function/prototype/bind/instance-length-default-value.js (default) Full Output: Exception: TypeError: Cannot convert a symbol to a number bind@[native code] global code@/Volumes/Data/worker/Apple-Ventura-AppleSilicon-Release-Test262-Tests/build/JSTests/test262/test/built-ins/Function/prototype/bind/instance-length-default-value.js:41:26 FAIL test/built-ins/Function/prototype/bind/instance-length-default-value.js (strict mode) Full Output: Exception: TypeError: Cannot convert a symbol to a number bind@[native code] global code@/Volumes/Data/worker/Apple-Ventura-AppleSilicon-Release-Test262-Tests/build/JSTests/test262/test/built-ins/Function/prototype/bind/instance-length-default-value.js:42:26 FAIL test/intl402/Collator/prototype/compare/compare-function-name.js (default) Full Output: Exception: Test262Error: descriptor should not be enumerable; descriptor should not be writable FAIL test/intl402/Collator/prototype/compare/compare-function-name.js (strict mode) Full Output: Exception: Test262Error: descriptor should not be enumerable; descriptor should not be writable FAIL test/intl402/DateTimeFormat/prototype/format/format-function-name.js (default) Full Output: Exception: Test262Error: descriptor should not be enumerable; descriptor should not be writable FAIL test/intl402/DateTimeFormat/prototype/format/format-function-name.js (strict mode) Full Output: Exception: Test262Error: descriptor should not be enumerable; descriptor should not be writable FAIL test/intl402/NumberFormat/prototype/format/format-function-name.js (default) Full Output: Exception: Test262Error: descriptor should not be enumerable; descriptor should not be writable FAIL test/intl402/NumberFormat/prototype/format/format-function-name.js (strict mode) Full Output: Exception: Test262Error: descriptor should not be enumerable; descriptor should not be writable

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-03-21 18:30:47 PDT

<rdar://problem/107032476>

Robert Jenner

Comment 2 2023-03-21 18:33:09 PDT

Starting on Yusuke who introduced: https://commits.webkit.org/261825@main that appears to have caused these test failures.

Yusuke Suzuki

Comment 3 2023-03-21 20:32:54 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11795

EWS

Comment 4 2023-03-21 21:48:44 PDT

Committed 261945@main (24e437b8d08f): <https://commits.webkit.org/261945@main> Reviewed commits have been landed. Closing PR #11795 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.