Bug 254076
Summary: | MediaSource duration change algorithm incorrectly update the duration | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 225367 |
Jean-Yves Avenard [:jya]
Per the duration change algorithm [1]
```
4. If new duration is less than highest end time, then
Note :This condition can occur because the coded frame removal algorithm preserves coded frames that start before the start of the removal range.
1. Update new duration to equal highest end time.
Update duration to new duration.
```
However
https://searchfox.org/wubkat/rev/0df98689c59d069de39d9ddb7e7fe403bf15070e/Source/WebCore/Modules/mediasource/MediaSource.cpp#520-525
we set the duration to the value originally passed.
This causes the test `LayoutTests/media/media-source/media-source-play.html` when run in the GPU test, this wasn't an issue when the MockMSE runs in the content process as it always reads the duration from the parent MSE instead which is correct.
[1] https://w3c.github.io/media-source/#dfn-duration-change
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106858912>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/11654
EWS
Committed 261830@main (8575978fe5ef): <https://commits.webkit.org/261830@main>
Reviewed commits have been landed. Closing PR #11654 and removing active labels.