Bug 25405

Summary:

[GTK] layout tests cleanup

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

xan.lopez

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
fix timeout in post-goback-same-url.html	none
fix timeout in post-goback-same-url.html	none
Use SoupURI to resolve URLs	aroben: review+

Gustavo Noronha (kov)

Reported 2009-04-25 21:09:40 PDT

I intend to do some work to cleanup/fix issues with current failing tests in the GTK+ port. I'm opening this bug to track progress, instead of opening one for each thing.

Attachments
fix timeout in post-goback-same-url.html (1.86 KB, patch) 2009-04-25 21:12 PDT, Gustavo Noronha (kov)	no flags	Details Formatted Diff Diff
fix timeout in post-goback-same-url.html (1.85 KB, patch) 2009-04-26 11:03 PDT, Gustavo Noronha (kov)	no flags	Details Formatted Diff Diff
Use SoupURI to resolve URLs (2.21 KB, patch) 2009-04-26 21:02 PDT, Gustavo Noronha (kov)	aroben: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2009-04-25 21:12:20 PDT

Created attachment 29797 [details] fix timeout in post-goback-same-url.html WebKitTools/ChangeLog | 10 ++++++++++ .../DumpRenderTree/gtk/LayoutTestControllerGtk.cpp | 15 +++++++++++++-- 2 files changed, 23 insertions(+), 2 deletions(-)

Gustavo Noronha (kov)

Comment 2 2009-04-25 21:14:22 PDT

Comment on attachment 29797 [details] fix timeout in post-goback-same-url.html This fixes LayoutTestController::queueLoad to "resolve" relative URLs. It's a pitty it seems we have no sane API to do such things in glib, so I did it using some string handling. It fixes the timeout for that test.

Gustavo Noronha (kov)

Comment 3 2009-04-26 11:03:57 PDT

Created attachment 29804 [details] fix timeout in post-goback-same-url.html WebKitTools/ChangeLog | 10 ++++++++++ .../DumpRenderTree/gtk/LayoutTestControllerGtk.cpp | 15 +++++++++++++-- 2 files changed, 23 insertions(+), 2 deletions(-)

Gustavo Noronha (kov)

Comment 4 2009-04-26 11:05:32 PDT

Comment on attachment 29804 [details] fix timeout in post-goback-same-url.html Fixes the way we figure out the size of the string to init the GString, as Xan pointed out the other method would go wrong with utf8 file names.

Xan Lopez

Comment 5 2009-04-26 11:07:01 PDT

Comment on attachment 29804 [details] fix timeout in post-goback-same-url.html Looks good.

Gustavo Noronha (kov)

Comment 6 2009-04-26 21:02:04 PDT

I actually found that my method has problems with other tests that had escaped my tests, unfortunately. I cooked a new patch using SoupURI, which thankfully has a way of creating SoupURIs with base/relative.

Gustavo Noronha (kov)

Comment 7 2009-04-26 21:02:34 PDT

Created attachment 29811 [details] Use SoupURI to resolve URLs WebKitTools/ChangeLog | 10 ++++++++++ .../DumpRenderTree/gtk/LayoutTestControllerGtk.cpp | 18 ++++++++++-------- 2 files changed, 20 insertions(+), 8 deletions(-)

Adam Roben (:aroben)

Comment 8 2009-04-27 06:37:17 PDT

Comment on attachment 29811 [details] Use SoupURI to resolve URLs Do we need any error-checking in queueLoad? r=me

Gustavo Noronha (kov)

Comment 9 2009-04-27 07:55:39 PDT

Landed as r42890, with a null-check for absoluteURI.

Note You need to log in before you can comment on or make changes to this bug.