Bug 253877
| Summary: | [GLib] No render update when seeking outside of network buffer in fullscreen | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kdwk <kdwkleung> |
| Component: | WebKitGTK | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aboya, bugs-noreply, caden, eocanha, mcatanzaro, philn |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Kdwk
In YouTube videos, when seeking outside the network buffer, the whole player area (fullscreened) would sometimes not update, until manually un-fullscreening and fullscreening again.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kdwk
Screencast showing YouTube player not updating until un-fullscreening after seeking: http://kdwk.tplinkdns.com/index.php/s/CPo3Mi6am8sHAeK
Kdwk
Tested on WebKitGTK 2.39.91, Epiphany Technology Preview 44.rc-22-gf847def6c+, GStreamer 1.20.5
Philippe Normand
Can you confirm this is specific to the VA+DMABuf sink combo?
Kdwk
Just checked. Happens with no environment variables as well (non-VA, non-DMABuf)
Philippe Normand
This is not related with GStreamer/MSE, but with Fullscreen handling, which is implemented differently in GLib vs Apple ports (those rely on ENABLE(VIDEO_PRESENTATION_MODE) which we should at some point do too...).
Anyhow... with a Chrome UA it works. Shrug.
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/11696
EWS
Committed 261839@main (4ad4b2d3a795): <https://commits.webkit.org/261839@main>
Reviewed commits have been landed. Closing PR #11696 and removing active labels.
Michael Catanzaro
*** Bug 254480 has been marked as a duplicate of this bug. ***
Michael Catanzaro
I wish we knew why the UA quirk affects rendering updates as that seems like something websites should not be able to break no matter what they do wrong....
Kdwk
Reporting browser as Chrome apparently also enables ‘scroll for more information’, which allows users to scroll directly to to the comments section from the fullscreened video.
Philippe Normand
(In reply to kdwkleung from comment #10)
> Reporting browser as Chrome apparently also enables ‘scroll for more
> information’, which allows users to scroll directly to to the comments
> section from the fullscreened video.
Is that considered a bug or a feature? :)
Kdwk
Feature. Chrome and Firefox also support this.
Caden Mitchell
I can confirm this is now fixed in the latest technology preview. Would be nice to see this land in the stable version sometime soon as this could really improve the user experience. Thanks for all the hard work, guys!
Michael Catanzaro
This is on the backports list for 2.40.1.
(That said, I repeat my warning that it's fragile and may need to be removed in the future.)