Bug 253819

Summary: Refactor list-style-type conversion
Product: WebKit Reporter: Vitor Roriz <vitor.roriz>
Component: CSSAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: dpino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   

Vitor Roriz
Reported 2023-03-13 06:11:22 PDT
list-style-type is currently used to set a list style type and a list style string value. Currently, the StyleBuilderCustom always sets both values together. This refactoring will introduce a new type to explicitly associate these values, ListStyle, with a type and a name (string value). This is a preparation for @counter-style, since list-style-type's associated to custom-ident will always have CustomCounterStyle as ListStyleType (ListStyle.type) and will rely on the ListStyle.name to differentiate between the counter-styles.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-03-13 06:11:34 PDT
Vitor Roriz
Comment 2 2023-03-13 06:56:48 PDT
EWS
Comment 3 2023-03-14 15:05:50 PDT
Committed 261651@main (2fa477e5ad2e): <https://commits.webkit.org/261651@main> Reviewed commits have been landed. Closing PR #11437 and removing active labels.
Diego Pino
Comment 4 2023-03-15 01:23:35 PDT
WebKitGTK/WPE Ubuntu 20.04 post-commit build bots are failing after this patch: https://build.webkit.org/#/builders/595/builds/8399/steps/9/logs/stdio https://build.webkit.org/#/builders/596/builds/7990/steps/9/logs/stdio ``` /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/WebCore/platform/graphics/DestinationColorSpace.h:55:21: note: candidate: ‘bool WebCore::operator!=(const WebCore::DestinationColorSpace&, const WebCore::DestinationColorSpace&)’ 55 | WEBCORE_EXPORT bool operator!=(const DestinationColorSpace&, const DestinationColorSpace&); ```
Diego Pino
Comment 5 2023-03-15 01:24:45 PDT
EWS
Comment 6 2023-03-15 04:26:09 PDT
Committed 261680@main (b323e2ac5c49): <https://commits.webkit.org/261680@main> Reviewed commits have been landed. Closing PR #11541 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.