Bug 25375 – [GTK] Add translator comment to translatable message(s)

• Component: WebKitGTK
• Status: RESOLVED CONFIGURATION CHANGED

[Luca Ferretti]

#: WebCore/platform/gtk/LocalizedStringsGtk.cpp:66
msgid "_Searchable Index"

This is a translatable message for WebKitGtk. Could be good add here (and maybe on other messages) a little suggestion or tip or explanation about where the message will appear and its meaning, in order to help translators to produce a better work.

[Luca Ferretti]

#: WebCore/platform/gtk/LocalizedStringsGtk.cpp:179
msgid "No Guesses Found"

Another message that could need a tip for translators.

[Luca Ferretti]

#: WebCore/platform/gtk/LocalizedStringsGtk.cpp:262
msgid "_Outline"

Third message....

[Luca Ferretti]

Another stuff that could be good to clarify is the "minimum logical size" for fonts. It's explained here[1], but could be good add more info for translators and/or in gtk-doc stuff.

http://developer.apple.com/documentation/Cocoa/Reference/WebKit/Classes/WebPreferences_Class/Reference/Reference.html

[Christian Dywan]

Created attachment 83489 [details]
Document font sizes, no guesses found and outline

The search index string no longer exists. I documented the other items you mentioned and actually added gtk-doc comments for the minimum font size settings.

[Martin Robinson]

Comment on attachment 83489 [details]
Document font sizes, no guesses found and outline

View in context: https://bugs.webkit.org/attachment.cgi?id=83489&action=review

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:349
> +     * The smallest font size used for display if a website doesn't correctly
> +     * define it, which can happen with <small> elements or percentages.

I'm not sure that "doesn't correctly" is erm...correct here. It's not incorrect to use a logical font size. Perhaps something like this:

The minimum font size used for elements which do not absolutely declare their font sizes. Examples of non-absolute font sizes are those that are defined with words such as "small" or "large" or those defined relative to other font sizes with words like "larger,"  "smaller" or a percentage.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:356
> +    // i18n: The smallest font size used for display if a website doesn't correctly
> +    // define it, which can happen with <small> elements or percentages.

It seems redudant to have it both places.

[Christian Dywan]

Created attachment 84727 [details]
83489: Document font sizes, no guesses found and outline #2

(In reply to comment #5)
> (From update of attachment 83489 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83489&action=review
> 
> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:349
> > +     * The smallest font size used for display if a website doesn't correctly
> > +     * define it, which can happen with <small> elements or percentages.
> 
> I'm not sure that "doesn't correctly" is erm...correct here. It's not incorrect to use a logical font size. Perhaps something like this:
> 
> The minimum font size used for elements which do not absolutely declare their font sizes.
> Examples of non-absolute font sizes are those that are defined with words such as "small"
> or "large" or those defined relative to other font sizes with words like "larger,"  "smaller" or a percentage.

Updated it:

The smallest font size used for display for elements which don't absolutely
declare their font sizes. Examples of that are "small", "smaller" or percentages.

I'm trying to keep it consise and focus on visual effect here. The examples are obvious enough to anyone who knows CSS.

> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:356
> > +    // i18n: The smallest font size used for display if a website doesn't correctly
> > +    // define it, which can happen with <small> elements or percentages.
> 
> It seems redudant to have it both places.

It isn't. Translators don't read developer documentation. Many don't event test what they translate.

[Martin Robinson]

Comment on attachment 84727 [details]
83489: Document font sizes, no guesses found and outline #2

View in context: https://bugs.webkit.org/attachment.cgi?id=84727&action=review

Looks good, but please fix the remaining issues when landing.

> Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:239
> +    // i18n: Context menu item, if spell checking found no correction suggestions

Please add a period to this sentence when landing.

> Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:323
> +    // i18n: Unused, font markup menu item

Please complete this sentence and add a period.

[Eric Seidel (no email)]

Attachment 84727 [details] was posted by a committer and has review+, assigning to Christian Dywan for commit.

[Eric Seidel (no email)]

I don't think this was ever landed.