Bug 253741
| Summary: | Avoid including Document.h in DocumentParser and JSObject.h in JSSegmentedVariableObject.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
The Document.h and JSObject.h headers are very costly. They are included in a few places where they are not used:
1. DocumentParser.h doesn't need to include the header, and already includes it in its implementation file.
2. JSSegmentedVariableObject.h doesn't use the contents of JSObject.h at all, so pays a heavy price for no benefit.
These two changes save about 4 minutes of CPU time parsing, and about 0.75 minutes of codegen.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106579489>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/11392
EWS
Committed 261538@main (f19ec43b3605): <https://commits.webkit.org/261538@main>
Reviewed commits have been landed. Closing PR #11392 and removing active labels.