REGRESSION(261079@main): "KeyError: 'h2'" when running tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sam Sneddon [:gsnedders]]

We've seen this happen in some configurations, on some occasions.

rdar://106437906

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/11255

[Ben Nham]

*** Bug 253594 has been marked as a duplicate of this bug. ***

[EWS]

Committed 261389@main (cd833210c0e7): <https://commits.webkit.org/261389@main>

Reviewed commits have been landed. Closing PR #11255 and removing active labels.

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/11289

[Diego Pino]

After this patch the EWS GTK-WK2 (LayoutTest) bot started failing with the following error:

```
NameError raised: name 'self' is not defined
Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 92, in main
    run_details = run(port, options, args, stderr)
  File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 506, in run
    printer.print_config(port.results_directory())
  File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/views/printing.py", line 93, in print_config
    self._print_default('Command line: ' + ' '.join(self._port.driver_cmd_line_for_logging()))
  File "/app/webkit/Tools/Scripts/webkitpy/port/base.py", line 666, in driver_cmd_line_for_logging
    driver = self.create_driver(0)
  File "/app/webkit/Tools/Scripts/webkitpy/port/base.py", line 929, in create_driver
    return driver.DriverProxy(self, worker_number, self._driver_class(), pixel_tests=self.get_option('pixel_tests'), no_timeout=no_timeout)
  File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 834, in __init__
    self._driver = self._make_driver(pixel_tests)
  File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 838, in _make_driver
    return self._driver_instance_constructor(self._port, self._worker_number, pixel_tests, self._no_timeout)
  File "/app/webkit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 46, in __init__
    Driver.__init__(self, *args, **kwargs)
  File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 196, in __init__
    self.web_platform_test_server_base_http_url = self._port.web_platform_test_server_base_http_url()
  File "/app/webkit/Tools/Scripts/webkitpy/port/base.py", line 1039, in web_platform_test_server_base_http_url
    return web_platform_test_server.base_http_url(self, localhost_only)
  File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py", line 55, in base_http_url
    config = wpt_config_json(port_obj)
  File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py", line 47, in wpt_config_json
    if port_obj.supports_localhost_aliases and not self._port_obj.get_option('disable_wpt_hostname_aliases'):
NameError: name 'self' is not defined
Exception ignored in: <function Driver.__del__ at 0x7f350693fa30>
Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 204, in __del__
    self.stop()
  File "/app/webkit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 197, in stop
    self._xvfb_stop()
  File "/app/webkit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 113, in _xvfb_stop
    if self._xvfb_process:
AttributeError: 'XvfbDriver' object has no attribute '_xvfb_process'
```

For instance:

https://ews-build.webkit.org/#/builders/35/builds/45358/steps/17/logs/stdio

Actually the EWS GTK-WK2 failed with the same error on this PR:

https://ews-build.webkit.org/#/builders/35/builds/45358/steps/17/logs/stdio

[EWS]

Committed 261426@main (58d744e9d380): <https://commits.webkit.org/261426@main>

Reviewed commits have been landed. Closing PR #11289 and removing active labels.