Bug 25343 – -webkit-box-shadow with 0,0 offset ignores blur

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Nate Chapin]

Regression introduced in http://trac.webkit.org/changeset/42375

If -webkit-box-shadow is used with height and width of 0, the blur value is being ignored.  This is causing LayoutTests/fast/repaint/box-shadow-h.html and LayoutTests/fast/repaint/box-shadow-v.html to fail.

[Nate Chapin]

Created attachment 29711 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 29711 [details]
Patch

Good work and welcome :)

A couple of things about ChangeLog contents. It's actually very handy (like when perusing trac), so we really try to put more details there. This would be a good ChangeLog entry:

2009-04-22  Nate Chapin  <[e-mail]>

        Reviewed by NOBODY (OOPS!).

        https://bugs.webkit.org/show_bug.cgi?id=25343
        Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset ignores blur.

        * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow): Added an extra check for blur.

In other words:

 * URL of the bug
 * Brief description of the bug
 * For each change, brief documentation of what it is.

r-, but only because of this.

> [phone]  Nate Chapin  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
> +:
> +

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 42752)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,10 @@
> [phone]  Nate Chapin  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
> +:
> +
>  2009-04-14  Xan Lopez  <[e-mail]>
>  
>          Unreviewed version bump in preparation for 1.1.5 release.
> Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
> ===================================================================
> --- WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	(revision 42752)
> +++ WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	(working copy)
> @@ -963,7 +963,7 @@ void GraphicsContext::setPlatformShadow(
>          return;
>  
>      // Detect when there's no effective shadow and clear the looper.
> -    if (size.width() == 0 && size.height() == 0) {
> +    if (size.width() == 0 && size.height() == 0 && blurInt == 0) {
>          platformContext()->setDrawLooper(NULL);
>          return;
>      }

[Nate Chapin]

Created attachment 29747 [details]
Patch2

[Dimitri Glazkov (Google)]

Comment on attachment 29747 [details]
Patch2

There's an errant floatey colon at the end of ChangeLog, but I'll clean up when landing.

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/42833.