Bug 25305

Summary:

can't run safari or drt on windows

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, sfalken

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll	sam: review+
Fix running run-safari and run-webkit-tests from outside the source tree	sam: review+
[1/3] Fix JavaScriptCore build on VC++ Express	sfalken: review+
[2/3] Rename JavaScriptCore_debug.dll to JavaScriptCore.dll	sfalken: review+
[3/3] Fix running run-safari and run-webkit-tests from outside the source tree	sfalken: review+

Ojan Vafai

Reported 2009-04-20 19:34:33 PDT

Filing at aroben's request. Running Safari.exe from %TEMP%\WebKitNightly gave an error about CoreFoundation.dll missing and running run-webkit-tests crashed on each test. Adding "%TEMP%\WebKitNightly;C:\Program Files\Safari;" got run-safari to start. I tried copying the DLLs as suggested at http://trac.webkit.org/wiki/BuildingOnWindows#Runningthetests, excluding WebKit.dll and now both run-safari and DumpRenderTree.exe crash on startup (more specifically, pull up the VS debugger). Running Safari.exe from %TEMP%\WebKitNightly from gives the CoreFoundation.dll error again.

Attachments
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll (24.39 KB, patch) 2009-04-21 10:54 PDT, Adam Roben (:aroben)	sam: review+	Details Formatted Diff Diff
Fix running run-safari and run-webkit-tests from outside the source tree (2.94 KB, patch) 2009-04-21 10:55 PDT, Adam Roben (:aroben)	sam: review+	Details Formatted Diff Diff
[1/3] Fix JavaScriptCore build on VC++ Express (3.37 KB, patch) 2009-04-21 11:01 PDT, Adam Roben (:aroben)	sfalken: review+	Details Formatted Diff Diff
[2/3] Rename JavaScriptCore_debug.dll to JavaScriptCore.dll (23.79 KB, patch) 2009-04-21 11:01 PDT, Adam Roben (:aroben)	sfalken: review+	Details Formatted Diff Diff
[3/3] Fix running run-safari and run-webkit-tests from outside the source tree (2.94 KB, patch) 2009-04-21 11:02 PDT, Adam Roben (:aroben)	sfalken: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2009-04-21 10:44:14 PDT

I was able to reproduce these problems, and I think I have a patch that fixes them.

Adam Roben (:aroben)

Comment 2 2009-04-21 10:54:57 PDT

Created attachment 29653 [details] Rename JavaScriptCore_debug.dll to JavaScriptCore.dll

Adam Roben (:aroben)

Comment 3 2009-04-21 10:55:15 PDT

Created attachment 29654 [details] Fix running run-safari and run-webkit-tests from outside the source tree

Adam Roben (:aroben)

Comment 4 2009-04-21 11:01:33 PDT

Created attachment 29655 [details] [1/3] Fix JavaScriptCore build on VC++ Express

Adam Roben (:aroben)

Comment 5 2009-04-21 11:01:56 PDT

Created attachment 29656 [details] [2/3] Rename JavaScriptCore_debug.dll to JavaScriptCore.dll

Adam Roben (:aroben)

Comment 6 2009-04-21 11:02:15 PDT

Created attachment 29657 [details] [3/3] Fix running run-safari and run-webkit-tests from outside the source tree

Adam Roben (:aroben)

Comment 7 2009-04-21 11:09:29 PDT

Landed as r42717, r42718, and r42719

Note You need to log in before you can comment on or make changes to this bug.