Bug 252975

Summary:

[margin-trim] shouldChildInlineMarginContributeToContainerIntrinsicSize should take into consideration text

Product:

WebKit

Reporter:

Sammy Gill <sgill26>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

bfulgham, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Testcase	none

Sammy Gill

Reported 2023-02-26 21:13:08 PST

Created attachment 465194 [details] Testcase The attached test case shows how text can end up in a RenderBlockFlow. Currently shouldChildInlineMarginContributeToContainerIntrinsicSize is unable to handle such a case since it takes a RenderElement

Attachments
Testcase (470 bytes, text/html) 2023-02-26 21:13 PST, Sammy Gill	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-03-05 21:14:15 PST

<rdar://problem/106271482>

Sammy Gill

Comment 2 2023-03-06 09:45:46 PST

There better option here was to maintain the function signature as is since it makes more sense and then check the value we are trying to pass in at the call site. *** This bug has been marked as a duplicate of bug 253165 ***

Note You need to log in before you can comment on or make changes to this bug.