Bug 25292

Summary:

Apparent memory corruption running fast/js/math-transforms.html

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
gdb output of investigation	none
clear the frame name before running each test	gustavo: review+

Gustavo Noronha (kov)

Reported 2009-04-20 06:24:17 PDT

Trying to debug two failing tests on the GTK+ port I found out that they are failing because the frame name goes from empty to a very strange value: "someFloatString". This is caused by running the math-transforms test. I added small print statements to the beginning and the end of the FrameLoader::executeScript method to print the frame name, to make sure and this is the output I get when I navigate to that test using the launcher: name (executescript): name (executescript2): name (executescript): name (executescript2): someFloatString name (executescript): someFloatString name (executescript2): someFloatString This happens both in GTK+ and Qt. Haven't been able to try other platforms yet. I have used the print statements because I wasn't able to figure out a better way of tracking/nailing this problem; valgrind didn't show any suspicious writes, and I was unable to figure out a watch statement that would catch this in gdb. I am on Linux x86, and I have JIT enabled.

Attachments
gdb output of investigation (11.53 KB, text/plain) 2009-04-27 20:24 PDT, Gustavo Noronha (kov)	no flags	Details
clear the frame name before running each test (3.17 KB, patch) 2009-06-09 07:54 PDT, Jan Alonzo	gustavo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2009-04-27 20:24:00 PDT

Created attachment 29834 [details] gdb output of investigation I am still investigating this problem. Still not sure I'm on the right track, but I thought I'd post this output here, for it may be useful for someone familiar with the code.

Jan Alonzo

Comment 2 2009-06-09 07:54:21 PDT

Created attachment 31094 [details] clear the frame name before running each test someFloatString is apparently the frame name, so we need to make sure we clear the frame name before we run each test. This is also what mac does by the way.

Gustavo Noronha (kov)

Comment 3 2009-06-09 08:41:41 PDT

Comment on attachment 31094 [details] clear the frame name before running each test Since Mac is also doing it, sounds fine to me. But I wonder if we should not be clearing this as part of the normal load process?

Brent Fulgham

Comment 4 2009-06-10 10:26:38 PDT

Landed in @r44570.

Brent Fulgham

Comment 5 2009-06-10 10:27:25 PDT

Landed in @r44570.

Gustavo Noronha (kov)

Comment 6 2009-06-10 15:48:17 PDT

The DRT part was missing in the first commit. I just landed it in r44594.

Note You need to log in before you can comment on or make changes to this bug.