Bug 252588
| Summary: | Import wpt 'loading' WPT Tests from upstream | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | achristensen, ap, gsnedders, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
This is just a bug to try to import tests from WPT since I am working on patch, which will progress three of those tests.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105987852>
Alexey Proskuryakov
We usually import WPT tests when we are working on a particular fix or feature, not just to have more of them (the latter is actually undesirable, as they take a lot of time and effort to run).
Ahmad Saleem
(In reply to Alexey Proskuryakov from comment #2)
> We usually import WPT tests when we are working on a particular fix or
> feature, not just to have more of them (the latter is actually undesirable,
> as they take a lot of time and effort to run).
Yes, I was working on CSSPreloader fix, which fixed one of the testcase from here and other two, I am trying to fix. While remaining three pass already.
Alexey Proskuryakov
Sorry, I misread what you said - you are working on a fix too. Still, not sure if that warrants importing a whole directory of tests.
Ahmad Saleem
I manage to import /loading/ tests manually, I was working on and I am not working on /loading/early-hints/ folder, so I will close this bug and when needed, will create new to upstream remaining test cases.
As of STP179, we pass all tests in loading/ directory (except sub-directory /early-hints/).