Summary: | event handlers are undefined in v8 binding of XMLHttpRequest. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fumitoshi Ukai <ukai> | ||||||
Component: | JavaScriptCore | Assignee: | Fumitoshi Ukai <ukai> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Fumitoshi Ukai
2009-04-16 18:04:41 PDT
*** Bug 25258 has been marked as a duplicate of this bug. *** Created attachment 29570 [details]
use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding
Comment on attachment 29570 [details] use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding Great! Just two nits: > +2009-04-16 Fumitoshi Ukai <ukai@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Use null for unspecified event listener attributes of XMLHttpRequest and XMLHttpRequestUpload in v8 binding. > + https://bugs.webkit.org/show_bug.cgi?id=25257 > + cf.http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes > + An event handler attribute, unless otherwise specified, can either have the value null or be set to a Function object. > + Initially, an event handler attribute must be set to null. Indentation is off here as well as a line break missing? > +2009-04-16 Fumitoshi Ukai <ukai@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Verify XMLHttpRequest has correct attribute value by default. > + https://bugs.webkit.org/show_bug.cgi?id=25257 > + Ditto. Created attachment 29584 [details]
use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding - ChangeLog entries fixed
Thanks for reviewing.
Fixed ChangeLog entries.
ping? (In reply to comment #4) > Created an attachment (id=29584) [review] > use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload > of v8 binding - ChangeLog entries fixed > > Thanks for reviewing. > Fixed ChangeLog entries. > Landed as http://trac.webkit.org/changeset/42828. Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. |