Bug 25257 – event handlers are undefined in v8 binding of XMLHttpRequest.

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Fumitoshi Ukai]

XMLHttpRequest of v8 doesn't have correct event handlers by default.

For example, blogger.com uses the following snippet to detect whether the browser supports XMLHttpRequest.

function createXmlHttp() {
  if (window.XMLHttpRequest) {
    var r = new XMLHttpRequest();

    // some older version of mozilla had xmlhttprequest, but not
    // readystate. no reason to waste effort on them.
    if (r.readyState != null && typeof(r.onreadystatechange) != 'undefined') {
      return r;
    }
  } else {
    try {
      return new ActiveXObject("Microsoft.XMLHTTP");
    }
    catch (e) { 
      // do nothing because we just fall thorough to bottom...
    }
  }

  return null;
}

With v8 binding, r.onreadystatechange is undefined, so it is considered that the browser(chromium) doesn't support XMLHttpRequest.
v8 binding should return null if its event handler is not specified yet.

[Mark Rowe (bdash)]

*** Bug 25258 has been marked as a duplicate of this bug. ***

[Fumitoshi Ukai]

Created attachment 29570 [details]
use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding

[Dimitri Glazkov (Google)]

Comment on attachment 29570 [details]
use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding

Great! Just two nits:

> [phone]  Fumitoshi Ukai  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Use null for unspecified event listener attributes of XMLHttpRequest and XMLHttpRequestUpload in v8 binding.
> +	https://bugs.webkit.org/show_bug.cgi?id=25257
> +	cf.http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
> +	 An event handler attribute, unless otherwise specified, can either have the value null or be set to a Function object.
> +	 Initially, an event handler attribute must be set to null.

Indentation is off here as well as a line break missing?

> [phone]  Fumitoshi Ukai  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Verify XMLHttpRequest has correct attribute value by default.
> +	https://bugs.webkit.org/show_bug.cgi?id=25257
> +

Ditto.

[Fumitoshi Ukai]

Created attachment 29584 [details]
use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding - ChangeLog entries fixed

Thanks for reviewing.
Fixed ChangeLog entries.

[Fumitoshi Ukai]

ping?

(In reply to comment #4)
> Created an attachment (id=29584) [review]
> use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload
> of v8 binding - ChangeLog entries fixed
> 
> Thanks for reviewing.
> Fixed ChangeLog entries.
> 

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/42828.

[Darin Adler]

Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.