Bug 252558

Summary:	[GTK][WPE] UI process release log not shown
Product:	WebKit	Reporter:	Carlos Garcia Campos <cgarcia>
Component:	WebKitGTK	Assignee:	Carlos Garcia Campos <cgarcia>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply
Priority:	P2	Keywords:	Gtk
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Carlos Garcia Campos

Reported 2023-02-20 04:17:03 PST

The problem is that logLevelString() implementation in WebKit layer doesn't take RELEASE_LOG_DISABLED into account. Actually the implementation of logLevelString() in all layers does the same, getting th value of WEBKIT_DEBUG env var, but with a few differences. We can have a single implementation in WTF and use WTF::logLevelString() from WebCore and WebKit.

Attachments
Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2023-02-20 04:19:20 PST

Pull request: https://github.com/WebKit/WebKit/pull/10358

EWS

Comment 2 2023-02-21 02:39:16 PST

Committed 260601@main (173e3ebecf4f): <https://commits.webkit.org/260601@main> Reviewed commits have been landed. Closing PR #10358 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.