Bug 25251

Summary:

Crash when frame creation removes it from the parent

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
fix crash in fast/loader/frame-creation-removal.html	ap: review+

Description Gustavo Noronha (kov) 2009-04-16 16:03:18 PDT

This is tested by the fast/loader/frame-creation-removal.html layout test. After 35088 our port has mostly adapted to the new requirements, but not all. We were still not checking for the frame being removed from the parent after init, and before loadURLIntoChildFrame.

Comment 1 Gustavo Noronha (kov) 2009-04-16 16:20:43 PDT

Created attachment 29561 [details]
fix crash in fast/loader/frame-creation-removal.html

 WebKit/gtk/ChangeLog                               |   16 ++++++++++++++++
 WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp |    6 ++++++
 2 files changed, 22 insertions(+), 0 deletions(-)

Comment 2 Alexey Proskuryakov 2009-04-17 09:55:25 PDT

Comment on attachment 29561 [details]
fix crash in fast/loader/frame-creation-removal.html

r=me

> +    // Copied from Mac's FrameLoaderClient

I'd suggest omitting this line - this kind of info is best discovered via svn blame and reading ChangeLogs.

Comment 3 Gustavo Noronha (kov) 2009-04-17 11:47:48 PDT

Landed as r42617, accepting ap's suggestion, thanks!