Bug 252464
| Summary: | Scrollbar should be removed from overrideLogicalHeight() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tables | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across this:
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/1cc9cb769dcf8459c12636b58d058311722b0221
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#3393
^ Adding - cb->scrollbarLogicalHeight();
Fixes another WPT test (tested locally on webkit 260408@main) - percentage-sizing-of-table-cell-children-002.html
Just wanted to raise so we can fix this.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
It might also pass this - http://wpt.live/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html
Ahmad Saleem
It might also pass this - http://wpt.live/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html
EWS
Committed 260503@main (96361e7e318d): <https://commits.webkit.org/260503@main>
Reviewed commits have been landed. Closing PR #10260 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/105627946>