Summary: | <option> elements inside an <optgroup> are bold on Chromium | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Langley <agl> | ||||||||
Component: | Layout and Rendering | Assignee: | Adam Langley <agl> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | adele, mitz | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Adam Langley
2009-04-16 14:14:14 PDT
Created attachment 29550 [details]
patch
Comment on attachment 29550 [details]
patch
The code change is fine.
I don't think those comments belong in html4.css though. If anything, we need a comment in themeWin.css about why we're forcing the font to be inherited. Something like "Option font must be inherited because we depend on computing the size of the <select> based on the size of the options, and they must use the same font for that computation to be correct".
I hesitate to say anything about the Changelog, because I think we all usually say too little in the logs, but I think you can probably have a more concise explanation here.
This is really an r+, but I'd like you to edit the comments & ChangeLog before you checkin. If you do that, pretty much anyone can give you the final r+.
Nice work!
Created attachment 29553 [details]
patch
(Addressing adele's comments)
Created attachment 29555 [details]
patch
(missed bug link in the ChangeLog)
Comment on attachment 29555 [details]
patch
r+ based on adele's previous comments.
Landed as: http://trac.webkit.org/changeset/42597 |