Bug 252122
Summary: | REGRESSION (260129@main): [ macOS wk1 ] 67+ tests are a consistent failure | ||
---|---|---|---|
Product: | WebKit | Reporter: | Karl Rackler <rackler> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=252071 |
Karl Rackler
Description:
At least 67+ tests are consistently failing after landing 260129@main.
It is difficult to inspect each test as a group on the WebKit Results Database due to the lag time and urgency of many tests broken by the commit 260129@main.
I spot-checked a couple of tests to confirm.
This seems to be affecting the following kinds of tests and possibly others:
http/tests/referrer-policy-anchor
http/tests/referrer-policy-iframe
http/tests/referrer-policy-img
imported/w3c/web-platform-tests/html/dom/render-blocking
imported/w3c/web-platform-tests/remote-playback
This issue can be bisected to 260129@main using command:
run-webkit-tests --release --iterations=1 -1 imported/w3c/web-platform-tests/html/dom/render-blocking/parser-blocking-script.tentative.html
Test Run:
https://build.webkit.org/#/builders/705/builds/1206
Results:
https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK1-Tests/260129@main%20(1206)/results.html
History:
https://results.webkit.org/?limit=5000&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fdom%2Frender-blocking%2Fparser-blocking-script.tentative.html
Diff:
@@ -1,6 +1,6 @@
text
Some more text
-FAIL Rendering is blocked before render-blocking resources are loaded step_wait_func: Timed out waiting on condition
+FAIL Rendering is blocked before render-blocking resources are loaded assert_implements: undefined
PASS Parser-blocking script is evaluated
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105342840>
Karl Rackler
Revert: https://commits.webkit.org/260164@main
Brent Fulgham
Surprising this would cause test results to change. I’ll review further.
Karl Rackler
I confirmed after reverting 260129@main that test imported/w3c/web-platform-tests/html/dom/render-blocking/parser-blocking-script.tentative.html is consistently passing.
Brent Fulgham
The issue is that our code to activate features that are off by default (frequently true for WebKitLegacy code) didn't know about `mature`. This wasn't a problem previously because the `mature` flag was only used on features where they were on by default in modern and legacy WebKit.