Bug 252003
| Summary: | [GPU Process] [FormControls] Make it possible to draw a viewless NSCell | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=252427 https://bugs.webkit.org/show_bug.cgi?id=252723 |
||
| Bug Depends on: | |||
| Bug Blocks: | 249168 | ||
Said Abou-Hallawa
AppKit crashes if [NSCell drawWithFrame] is called out of the main thread with a non-nil NSView. And this is why a hack was added to WebControlWindow to silence this crash in 257981@main. To fix the crash and to remove the hack, a nil NSView will be passed to [NSCell drawWithFrame] instead of passing the fake one.
To provide the [NSCell drawWithFrame] with the settings that it used to get from the fake NSView, new AppKit SPIs will be used to explicitly set them from the drawing. An NSCell can be drawn without an NSView only if these SPIs are available.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105233927>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/9882
EWS
Committed 260210@main (b8b3d9929d7d): <https://commits.webkit.org/260210@main>
Reviewed commits have been landed. Closing PR #9882 and removing active labels.
Ryosuke Niwa
Re-opening for pull request https://github.com/WebKit/WebKit/pull/10052
EWS
Committed 260216@main (efa69875810d): <https://commits.webkit.org/260216@main>
Reviewed commits have been landed. Closing PR #10052 and removing active labels.