Bug 251638

Summary:	REGRESSION: [Ventura] 16 TestWebKitAPI.WebPushD tests failing/timing out
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	New Bugs	Assignee:	Alex Christensen <achristensen>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	achristensen, beidson, rackler, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=251485

Ryan Haddad

Reported 2023-02-02 15:05:24 PST

Seemingly after the Ventura bots + SDK were updated to 13.2, the following tests started failing/timing out TestWebKitAPI.WebPushDInjectedPushTest.HandleInjectedAES128GCMPush TestWebKitAPI.WebPushDInjectedPushTest.HandleInjectedAESGCMPush TestWebKitAPI.WebPushDInjectedPushTest.HandleInjectedEmptyPush TestWebKitAPI.WebPushDTest.GetPushSubscriptionWithMismatchedPublicToken TestWebKitAPI.WebPushDTest.NotificationClickExtendsITPCleanupTimerBy30Days TestWebKitAPI.WebPushDTest.PushSubscriptionExtendsITPCleanupTimerBy30Days TestWebKitAPI.WebPushDTest.TooManySilentPushesCausesUnsubscribe TestWebKitAPI.WebPushDTest.UnsubscribesOnClearingAllWebsiteData TestWebKitAPI.WebPushDTest.UnsubscribesOnClearingWebsiteDataForOrigin TestWebKitAPI.WebPushDTest.UnsubscribesOnServiceWorkerUnregisterTest TestWebKitAPI.WebPushDTest.UnsubscribeTest TestWebKitAPI.WebPushDMultipleLaunchTest.GetPushSubscriptionAfterDaemonRelaunch TestWebKitAPI.WebPushDTest.IgnoresSubscriptionOnPermissionDenied TestWebKitAPI.WebPushDTest.SubscribeFailureTest TestWebKitAPI.WebPushDTest.SubscribeTest TestWebKitAPI.WebPushDTest.UnsubscribesOnPermissionReset https://build.webkit.org/#/builders/705/builds/1082/steps/19/logs/stdio

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-02-02 15:05:48 PST

<rdar://problem/104979435>

Karl Rackler

Comment 2 2023-02-02 19:53:01 PST

TestWebKitAPI.WebPushDTest.UnsubscribesOnServiceWorkerUnregisterTest It has been a constant API timeout on macOS since 259665@main. <https://commits.webkit.org/259665@main> changed webpush so it most likely caused this timeout. Testing reproduction using 22A380. 259664@main --> Passed 259665@main --> Failed HISTORY: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebPushDTest.UnsubscribesOnServiceWorkerUnregisterTest This issue can be bisected to 259665@main using command: run-api-tests --debug --iterations=1 TestWebKitAPI.WebPushDTest.UnsubscribesOnServiceWorkerUnregisterTest

Alex Christensen

Comment 3 2023-02-02 23:47:15 PST

Pull request: https://github.com/WebKit/WebKit/pull/9586

EWS

Comment 4 2023-02-03 00:58:05 PST

Committed 259806@main (58201f5319e0): <https://commits.webkit.org/259806@main> Reviewed commits have been landed. Closing PR #9586 and removing active labels.

Karl Rackler

Comment 5 2023-02-03 09:14:36 PST

I confirmed after landing <https://commits.webkit.org/259806@main> that tests are consistently passing.

Note You need to log in before you can comment on or make changes to this bug.