Bug 251630
| Summary: | Some data task signposts are not ended properly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKit Misc. | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Nham
Sometimes, when a data task is cancelled, the didCompleteWithError method is not called. Since that is where we end data task signposts, this can lead to dropped signposts and incorrectly attributed resource loads in perf traces. To fix this, most the end of the signpost to the destructor instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ben Nham
<rdar://problem/104976161>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/9552
EWS
Committed 259826@main (6fb617ebe42b): <https://commits.webkit.org/259826@main>
Reviewed commits have been landed. Closing PR #9552 and removing active labels.