Bug 251432

Summary:	[web-animations] use the keyframe's StyleProperties to determine whether a property is set to "inherit" in a keyframe
Product:	WebKit	Reporter:	Antoine Quint <graouts>
Component:	Animations	Assignee:	Antoine Quint <graouts>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, graouts, koivisto, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Antoine Quint

Reported 2023-01-31 05:49:12 PST

Right now we determine whether a property is set to "inherit" in a keyframe by doing a string comparison when the Web Animations API is used to set keyframes. However, the StyleRuleKeyframe created for the keyframe has StyleProperties where the value is parsed, it seems safer to check the CSSValue rather than do a string comparison here.

Attachments
Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2023-01-31 05:52:11 PST

Pull request: https://github.com/WebKit/WebKit/pull/9378

EWS

Comment 2 2023-01-31 08:35:14 PST

Committed 259630@main (9de2e80cf70b): <https://commits.webkit.org/259630@main> Reviewed commits have been landed. Closing PR #9378 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2023-01-31 08:36:18 PST

<rdar://problem/104869270>

Note You need to log in before you can comment on or make changes to this bug.