Bug 251340

Summary:	Save some memory by not putting serialized valueID strings into a hash map
Product:	WebKit	Reporter:	Darin Adler <darin>
Component:	CSS	Assignee:	Darin Adler <darin>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Darin Adler

Reported 2023-01-29 16:22:53 PST

CSSPrimitiveValue saves strings of serialized values in a map to avoid recomputing them. This is wasteful for the serialized form of CSSValueID, since they are all precomputed at compile time. Putting them in the hash table is a waste of memory.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-01-29 16:23:32 PST

<rdar://problem/104803128>

Darin Adler

Comment 2 2023-01-29 22:14:19 PST

Pull request: https://github.com/WebKit/WebKit/pull/9301

EWS

Comment 3 2023-01-30 09:18:56 PST

Committed 259562@main (29c1dd855828): <https://commits.webkit.org/259562@main> Reviewed commits have been landed. Closing PR #9301 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.