Summary: | help prevent crash in chromium event handling | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antony Sargent <asargent> | ||||||
Component: | DOM | Assignee: | Dmitry Titov <dimich> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Antony Sargent
2009-04-10 13:19:40 PDT
Created attachment 29395 [details]
patch
Comment on attachment 29395 [details] patch Just some styling nits. > +This is some cleanup motivated by the crash in http://crbug.com/9775 , which > +happens because of calling window.open inside a window.onload handler. > + > +These changes are just part of the fix, along with some asserts to help prevent > +breakage on future changes. We usually indent these to the same col as "Reviewed By". > + // TODO(asargent) this check for hidden value being !empty is a workaround for TODO(asargent) -> FIXME:in WebKit world. > + // Once the fix for that is pulled into chromium we can remove the check here. > + if (!object->GetHiddenValue(key).IsEmpty()) { > + object->DeleteHiddenValue(getKey(listener->isInline())); > + } no brackets around one-liners. Created attachment 29396 [details]
patch v2
new patch addressing styling issues (good catches, thx!)
assignign to me for landing |