Summary: | TextMatches don't have a concept of active match | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Finnur Thorarinsson <finnur.webkit> | ||||||
Component: | New Bugs | Assignee: | Finnur Thorarinsson <finnur.webkit> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | sullivan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Finnur Thorarinsson
2009-04-08 16:33:29 PDT
Created attachment 29371 [details]
Allowing the TextMatch marker to specify active/not
Attached is a proposed patch that fixes this.
Comment on attachment 29371 [details] Allowing the TextMatch marker to specify active/not > Index: dom/Document.h > =================================================================== > --- dom/Document.h (revision 42365) > +++ dom/Document.h (working copy) > @@ -699,6 +699,8 @@ public: > void setRenderedRectForMarker(Node*, DocumentMarker, const IntRect&); > void invalidateRenderedRectsForMarkersInRect(const IntRect&); > void shiftMarkers(Node*, unsigned startOffset, int delta, DocumentMarker::MarkerType = DocumentMarker::AllMarkers); > + void setMarkersActive(Range*, bool); > + void setMarkersActive(Node*, unsigned, unsigned, bool); The two unsigned parameters here should be given names in this declaration since it's otherwise not clear what they represent. The patch otherwise seems fine to me. Please submit a new patch with this change. Created attachment 29377 [details]
Addressing review comments
Reviewed in half an hour. Not a bad turnaround. Not at all. :)
Landed as: http://trac.webkit.org/changeset/42393 And the follow-up bustage fix: http://trac.webkit.org/changeset/42394 |