Bug 250798
| Summary: | REGRESSION(258644@main): The <select> control looks dark when zooming in | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=249988 | ||
| Bug Depends on: | |||
| Bug Blocks: | 249168 | ||
Said Abou-Hallawa
Calling getRoundedBorderFor() was dropped in 258644@main when refactoring the MenuListButton drawing to go through GraphicsContext. This caused the left and right border gradients to be not clipped. And this made the background of the control part to be filled with the border gradient which is dark gray.
Because we do not have access to the RenderStyle in platform/graphics, we have to calculate getRoundedBorderFor() the control part rect in RenderTheme::paint() and pass it all the way to GraphicsContext and to DisplayList recorder.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://104196022
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/8799
EWS
Committed 259325@main (b6af447cab8c): <https://commits.webkit.org/259325@main>
Reviewed commits have been landed. Closing PR #8799 and removing active labels.