Bug 250729
| Summary: | Image controls should not be web exposed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> |
| Component: | New Bugs | Assignee: | Aditya Keerthi <akeerthi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Aditya Keerthi
The following test case incorrectly displays the image controls button:
<style>
#image-controls {
width: 100px;
height: 40px;
background-color: yellow;
}
button {
width: 60px;
}
</style>
<body>
<div id="image-controls" contenteditable="false">
<button id="image-controls-button"></button>
</div>
</body>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104352792>
Aditya Keerthi
Actually, data:text/html,<button id="image-controls-button"></button> is sufficient to reproduce.
Ryosuke Niwa
Maybe we can use shadow DOM for this?
Aditya Keerthi
Pull request: https://github.com/WebKit/WebKit/pull/8777
Aditya Keerthi
(In reply to Ryosuke Niwa from comment #3)
> Maybe we can use shadow DOM for this?
We already use shadow DOM for this – the issue is due to a logic error.
Ryosuke Niwa
(In reply to Aditya Keerthi from comment #5)
> (In reply to Ryosuke Niwa from comment #3)
> > Maybe we can use shadow DOM for this?
>
> We already use shadow DOM for this – the issue is due to a logic error.
Ah, yeah. Saw your patch.
EWS
Committed 259126@main (ac4e9ee871be): <https://commits.webkit.org/259126@main>
Reviewed commits have been landed. Closing PR #8777 and removing active labels.